Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG : Non digit quantity field submission - vault #89

Closed
tomik-z-cech opened this issue Mar 14, 2024 · 1 comment
Closed

BUG : Non digit quantity field submission - vault #89

tomik-z-cech opened this issue Mar 14, 2024 · 1 comment
Assignees
@tomik-z-cech
Labels
Bug Story Points : 1

Comments

@tomik-z-cech
Copy link
Owner

Describe the bug :
It is possible to submit non-digit quantity field value and site throws 500 error.

To Reproduce :

  • Add any item to Vault
  • Navigate to Vault
  • Try to change the quantity value to non-digit value
  • See server response

Expected behavior :
Vault is protected from wrong values and user is notified of the wrongdoing.

Screenshots :
N/A

Devices :
All devices.

Additional context :
Possible insufficient defense programming in views.py of vault app.
@tomik-z-cech tomik-z-cech self-assigned this Mar 14, 2024
@tomik-z-cech
Copy link
Owner Author

if new_quantity.isdigit(): used in post method of views.py in vault app.

Bug fixed in commit f90e353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomik-z-cech tomik-z-cech

Labels
Bug Story Points : 1
Projects
PP5 - Ohm-Azing Components
Status: Bugs
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomik-z-cech