Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open model file by clicking on model name #12

Closed
povilasjurcys opened this issue Sep 29, 2014 · 5 comments
Closed

Open model file by clicking on model name #12

povilasjurcys opened this issue Sep 29, 2014 · 5 comments

Comments

@povilasjurcys
Copy link
Contributor

Suppose I have given code

# ...
def foo
  Bar.baz
end
# ...

It would be awesome to open app/models/baz.rb file by clicking on "Bar" word

@tomkadwill
Copy link
Owner

Hey @Bloomrain, sorry for the late reply.

I've just seen your PR. Awesome idea! I'll have a look through and try to merge it in tonight. Then maybe we can work on adding some tests later on

@povilasjurcys
Copy link
Contributor Author

damn! I did not know about atom ctags plugin... It works better then my improvement :)

@tomkadwill
Copy link
Owner

Yes, ctags is nice :). I've merged your PR anyway. have a go with ctags and let me know if you think your PR is still necessary.

I wouldn't want to re-implement all of ctags but perhaps this would be a nice to have if the user doesn't have ctags installed. Might even be a good idea to add a conditional so that this is disabled if ctags is enabled.

@tomkadwill
Copy link
Owner

I've decided to revert the merge. It sounds like ctags has solved you problem :)

Let me know if that is not the case. Thanks for taking the time to make a commit

@povilasjurcys
Copy link
Contributor Author

Yeah, I think that's a good decision. ctags works better in most cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants