Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce telemetry noise #1625

Open
tomkerkhove opened this issue May 6, 2021 · 7 comments
Open

Reduce telemetry noise #1625

tomkerkhove opened this issue May 6, 2021 · 7 comments
Assignees
Labels
enhancement Enhancements for current features operations All issues related to operations

Comments

@tomkerkhove
Copy link
Owner

Proposal

Reduce telemetry noise by:

  • Reducing official Microsoft telemetry to warning only
  • Only log HTTP requests for /api/v1/health when it fails

Component

Resource Discovery, Scraper

Contact Details

No response

@tomkerkhove tomkerkhove added the feature-request New feature requests label May 6, 2021
@tomkerkhove tomkerkhove added this to the Scraper - v2.3.0 milestone May 6, 2021
@tomkerkhove tomkerkhove self-assigned this May 6, 2021
@tomkerkhove tomkerkhove added enhancement Enhancements for current features operations All issues related to operations and removed feature-request New feature requests labels Jul 7, 2021
@locmai
Copy link
Contributor

locmai commented Sep 27, 2021

Hi again! We are having a logging noise issue as well with both scraper and resource discovery even when we set the log level to error.

[18:40:15 INF] Request finished in 0.5297ms 200 text/plain; version=0.0.4
[18:40:17 INF] Request starting HTTP/1.1 GET http://x.y.z.w/api/v1/health?includeDependencies=false

Is this the same issue?

And could it possibly because of this webHostBuilder with no log level configuration?

@tomkerkhove
Copy link
Owner Author

I will add this to the checklist but the whole Serilog setup has to change for sure.

@geertn
Copy link

geertn commented Feb 2, 2022

We have the same issue. Is there any known workaround? This is currently our biggest source of logging adding up to our costs.

│ [09:18:12 INF] Request starting HTTP/1.1 GET http://10.11.10.181:8888/api/v1/health?includeDependencies=false - -                                                                                           │
│ [09:18:12 INF] Route matched with {action = "Get", controller = "Health"}. Executing controller action with signature System.Threading.Tasks.Task`1[Microsoft.AspNetCore.Mvc.IActionResult] Get(Boolean) on  │
│ [09:18:12 INF] Executed action Promitor.Agents.ResourceDiscovery.Controllers.HealthController.Get (Promitor.Agents.ResourceDiscovery) in 0.2218ms                                                            │
│ [09:18:12 WRN] {"RequestMethod": "GET", "RequestHost": "http://10.11.10.181:8888", "RequestUri": "/api/v1/health", "ResponseStatusCode": 200, "RequestDuration": "00:00:00.0004844", "RequestTime": "2022-0 │
│ [09:18:12 INF] Request finished HTTP/1.1 GET http://10.11.10.181:8888/api/v1/health?includeDependencies=false - - - 200 60 application/json;+charset=utf-8 0.6816ms                                         │

@tomkerkhove
Copy link
Owner Author

No but this will be fixed in the next version, sorry about that.

@locmai
Copy link
Contributor

locmai commented Feb 2, 2022

We have turned off the log on all environments for a while now to save the logging storage cost. We only turn it on QA env for debugging.

@cktwo
Copy link

cktwo commented Nov 9, 2022

Any news?

@tomkerkhove
Copy link
Owner Author

Nope but open to contributions for it though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements for current features operations All issues related to operations
Projects
Status: Todo
Development

No branches or pull requests

4 participants