Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure AD Pod Identity / Manage Identity #444

Closed
cnadolny opened this issue Mar 26, 2019 · 12 comments
Closed

Add support for Azure AD Pod Identity / Manage Identity #444

cnadolny opened this issue Mar 26, 2019 · 12 comments
Labels
agents:discovery-agent All issues related to the resource discovery agent agents:scraper All issues related to the scraping agent configuration All issues related to configuration integration:azure-monitor All issues related to Azure Monitor integration security All issues related to security

Comments

@cnadolny
Copy link
Contributor

Provide support to authenticate with aad-pod-identity, using User Assigned Managed Identity.

@tomkerkhove tomkerkhove added configuration All issues related to configuration integration:azure-monitor All issues related to Azure Monitor integration security All issues related to security labels Mar 26, 2019
@tomkerkhove tomkerkhove added this to the v1.1.0 milestone Apr 14, 2019
@tomkerkhove tomkerkhove modified the milestones: v1.1.0, v1.2.0 Jun 26, 2019
@tomkerkhove tomkerkhove modified the milestones: v1.2.0, v1.1.0 Oct 6, 2019
@tomkerkhove tomkerkhove modified the milestones: v1.1.0, v1.2.0 Oct 24, 2019
@tomkerkhove tomkerkhove changed the title Add support for Azure AD Pod Identity Add support for Azure AD Pod Identity / Manage Identity Dec 20, 2019
@tomkerkhove tomkerkhove modified the milestones: v1.2.0, v1.3.0 Jan 8, 2020
@tomkerkhove
Copy link
Owner

Checking how we should authenticate for our Azure Monitor integration: Azure/azure-libraries-for-net#960

@tomkerkhove tomkerkhove modified the milestones: v1.3.0, v1.4.0 Jan 30, 2020
@tomkerkhove tomkerkhove modified the milestones: v1.4.0, v1.6.0, v1.5.0 Mar 20, 2020
@tomkerkhove tomkerkhove modified the milestones: v1.5.0, v1.6.0, v1.7.0 Apr 6, 2020
@tomkerkhove tomkerkhove added agents:scraper All issues related to the scraping agent agents:discovery-agent All issues related to the resource discovery agent labels Apr 21, 2020
@tomkerkhove tomkerkhove modified the milestones: v1.7.0, v1.8.0 May 11, 2020
@tomkerkhove tomkerkhove removed this from the Scraper - v2.1.0 milestone Jan 15, 2021
@Mimetis
Copy link
Contributor

Mimetis commented Mar 3, 2021

Hello @tomkerkhove
I'm currently working on the Managed Identity integration within Promitor.

I have already done the job for the Promitor.Agents.Scraper and I'm currently working on the Promitor.Agents.ResourceDiscovery to have a complete integration.

Basically, integrating the managed identity will lead to have a new flag indicating if we are using, or not, the managed identity system.

IF user choose to use the managed identity, he will be able to use its own User Managed Identity (by provider the GUID) or instead uses the System Assigned Identity (affected by Pod Identity for instance)

Here is a small screenshot of using Managed Identity within Promitor using the Scraper only:

image

I guess I will submit a PR by the end of the week.
Let me know if you have any question, or suggestions !

@tomkerkhove
Copy link
Owner

Awesome, thanks a ton!

Can you share a bit of what it looks like in terms of configuration?

Ideally the server.yml is extended with an authentication section which contains mode: ManagedIdentity|ServicePrinciple. Is that the case?

Just out of curiosity, are you also willing to write a new walkthrough, similar to this one, on how to configure it end to end?

@Mimetis
Copy link
Contributor

Mimetis commented Mar 3, 2021

Hey @tomkerkhove

I will open the Pull Request really soon but the work is not done yet, I'm still working on the Resource Discovery project.
I will expand everything I did so far, with details and we can have a discussion there.

Looking at the mode: For now, I'm still using the environment variables with a flag that can be omit (or not, depending the discussion we will have soon :) )

Regarding the walkthrough, we can think about it later; of course ! (well... hum... my English is not as good as it should be ;))

@jcorioland
Copy link
Contributor

@Mimetis @tomkerkhove happy to help on the walkthrough :-)

@tomkerkhove
Copy link
Owner

That would be awesome, thanks @jcorioland!

@Mimetis I'll take a look at your PR asap! Would you mind moving the configuration of the mode to the server YAML in the meantime please? Thanks!

@Mimetis
Copy link
Contributor

Mimetis commented Mar 4, 2021

@tomkerkhove Really depends if we need to have the mode somewhere actually.
Have a look to the PR, it's a discussion we should have :)

@tomkerkhove
Copy link
Owner

We're using configuration as code so think we should. I'm not a fan of automagic configuration but will check.

@tomkerkhove
Copy link
Owner

tomkerkhove commented Mar 11, 2021

I'll create a tasklist for this feature:

Just out of curiosity @jcorioland, when will you have the bandwidth for this?

@jcorioland
Copy link
Contributor

@tomkerkhove I am off next week, so probably not before the week after. I'll keep you posted.

@Mimetis
Copy link
Contributor

Mimetis commented Mar 11, 2021

@tomkerkhove, @jcorioland: I will start working on a walkthrough next week, probably with the help of @dupuyjs.

@tomkerkhove
Copy link
Owner

Awesome, thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents:discovery-agent All issues related to the resource discovery agent agents:scraper All issues related to the scraping agent configuration All issues related to configuration integration:azure-monitor All issues related to Azure Monitor integration security All issues related to security
Projects
None yet
Development

No branches or pull requests

4 participants