Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing a Settings Editor #128

Open
tomlin7 opened this issue Oct 1, 2023 · 2 comments
Open

Writing a Settings Editor #128

tomlin7 opened this issue Oct 1, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request file management text editor Related to text editor's features

Comments

@tomlin7
Copy link
Owner

tomlin7 commented Oct 1, 2023

The settings editor is not functional in this stage. The configurations done from the editor won't take effect on the actual config. Implementing the settings editor is important. Atleast biscuit should open the configuration files when asked for settings to edit the config within biscuit itself for now.

@tomlin7 tomlin7 added enhancement New feature or request text editor Related to text editor's features file management labels Oct 1, 2023
@tomlin7 tomlin7 self-assigned this Oct 1, 2023
@vyshnav-vinod
Copy link
Contributor

Ok so i noticed this issue while using the editor and found that the settings page does not do anything and configs are not saved. I was thinking since it is using CheckButton() maybe we can utilize the command argument of CheckButton() and maybe call a function which will change the configs and whenever the editor is closed, only then we actually write into settings.toml instead of writing it to settings.toml everytime we change a setting.

@tomlin7
Copy link
Owner Author

tomlin7 commented Mar 18, 2024

The config loader part of biscuit was removed temporarily as I thought of rewriting it properly. So currently biscuit doesn't load or handle any config files. Though I'd like the community's suggestions on writing a new system in place.

  • Use of sqlite3 databases instead of json/toml files
    this would make the configurations only changeable within the editor (from settings editor)

@tomlin7 tomlin7 pinned this issue Mar 18, 2024
@tomlin7 tomlin7 changed the title Making the Settings editor functional Writing a Settings Editor Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request file management text editor Related to text editor's features
Projects
None yet
Development

No branches or pull requests

2 participants