Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On deinit warning, also log location where the PromiseSource was created #14

Closed
mac-cain13 opened this issue Dec 3, 2015 · 3 comments
Closed

Comments

@mac-cain13
Copy link
Contributor

This would be very valuable when trying to fix the error, maybe only capture/print this info in debug mode since it is a bit sensitive info.

The magic constants like __FUNCTION__ should make this possible.

@tomlokhorst
Copy link
Owner

This is indeed very useful.

We should also think about how to handle PromiseSources created by combinators like map and flatMap.

Promises often go through a stack combinators, like: somePromise.map(...).mapError(...).flatMapResult(...).
We probably want to print the entire stack, since either end isn't sufficient information. Especially when a promise has been passed around a bunch.

@mac-cain13
Copy link
Contributor Author

Yeah, agreed. I think a promise based on another PromiseSource should print the location of the origional source. Or if possible the whole stacktrace indeed, but I don't know how much value that adds.

@tomlokhorst
Copy link
Owner

This is being worked on in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants