Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid remove dots on adapter data refresh #93

Closed
dybuk87 opened this issue Jul 10, 2020 · 1 comment
Closed

Invalid remove dots on adapter data refresh #93

dybuk87 opened this issue Jul 10, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@dybuk87
Copy link

dybuk87 commented Jul 10, 2020

Hi,

I found a bug when you have for example list with 5 elements and then you change item count to for example two and trigger notifyDataSetChange()

When this is triggered I have 3 dots but it does remove the first two dots. This causes an issue that I end up with one active dot (first one active when I am no last image, and all not active for other image)

This line cause bug

When I change it to this:
linearLayout!!.removeViewAt(linearLayout!!.childCount - 1)

It works ok, so I think this is a valid fix for that issue

@tommybuonomo tommybuonomo added this to the 4.3 milestone Apr 30, 2022
@tommybuonomo tommybuonomo self-assigned this Apr 30, 2022
@tommybuonomo
Copy link
Owner

Hello, thanks for your contribution !
This issue is now fixed in the new version 4.3
Thanks 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants