Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nth root function #13

Merged
merged 1 commit into from Aug 28, 2022
Merged

Conversation

jmcwilliams403
Copy link
Contributor

Documentation is very rough and I would recommend additional clarification all around.

Also I'm not sure how essential the extra check afterwords really is, so maybe some tests can be done with and without it.

Documentation is very rough and I would recommend additional clarification all around.

Also I'm not sure how essential the extra check afterwords really is, so maybe some tests can be done with and without it.
Copy link
Owner

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look fine to me; the only thing that occurs as a possible improvement is mentioning the tolerance this has for rounding (the same as isEqual(float, float)). I don't think that's needed, though. Approved!

@tommyettinger tommyettinger merged commit 6afa446 into tommyettinger:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants