Added float/double literals for sqrt 2/3/5 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally considered of putting root 2 and root 3 in trigTools and then root 5 in math tools, but I decided it would have probably made the organization needlessly confusing; However, in the documentation I did point out that the former two have useful properties in trigonometry, so I'll leave it open to further judgement.
|
Looks great, especially since some of my noise code redefines these over and over again. Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally considered of putting root 2 and root 3 in trigTools and then root 5 in math tools, but I decided it would have probably made the organization needlessly confusing; However, in the documentation I did point out that the former two have useful properties in trigonometry, so I'll leave it open to further judgement.