Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeDictionary Inheritance? #17

Closed
jimfoltz opened this issue Feb 10, 2018 · 3 comments
Closed

AttributeDictionary Inheritance? #17

jimfoltz opened this issue Feb 10, 2018 · 3 comments

Comments

@jimfoltz
Copy link
Contributor

Should AttributeDictionary inherit from Entity?

If I remember correctly, Classifications are implemented using a hierarchy of Dictionaries, and so to access all that you need to get the attribute_dictionaries() of an AttributeDictionary through the parent Entity class.

@Eneroth3
Copy link

In the Ruby API nested dictionaries can be used. I have used it myself on some rare occasion. Though I can't say anything about how the C API is designed it would make sense with such an inheritance.

@TommyKaneko
Copy link
Owner

Well, the C API has the function SUAttributeDictionaryToEntity(), so the C API recognises it as inheriting from Entity. Will need to make the necessary changes to the code.

@TommyKaneko
Copy link
Owner

The class has been amended to inherit from Entity in 570c7a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants