Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream uptime and PiP when closing app #198

Closed
TechGeeksIO opened this issue Sep 14, 2022 · 3 comments · Fixed by #218
Closed

Stream uptime and PiP when closing app #198

TechGeeksIO opened this issue Sep 14, 2022 · 3 comments · Fixed by #218
Assignees
Labels
feature request A desirable feature that should be added

Comments

@TechGeeksIO
Copy link

TechGeeksIO commented Sep 14, 2022

First of all, thanks for this great project and your work, I really appreciate it!

I have two feature requests,

  • adding stream uptime next to the viewers count
  • automatically switch to PiP when closing the app
  • Optional: PiP while browsing other streams.

Thank you! Enjoy the coffee 😊

@TechGeeksIO TechGeeksIO added the feature request A desirable feature that should be added label Sep 14, 2022
@IS2511
Copy link

IS2511 commented Oct 1, 2022

automatically switch to PiP when closing the app

Would be very appreciated, should be a setting probably, bump

@zeykafx
Copy link

zeykafx commented Oct 18, 2022

I added PiP when leaving the app, swipe controls, and Matrerial Design 3 on my fork of the app, I will see if I make a pull request or not because I'm not confident enough in my code 😆

@tommyxchow tommyxchow self-assigned this Dec 18, 2022
@tommyxchow
Copy link
Owner

Hey, thank you for the support and apologies for the (obviously) very late response. I was a bit burnt out from working on Frosty and decided to take a break to focus on other things and regain my motivation.

Anyways - on Android, I've rebuilt the PiP functionality with a newer package so that it enters PiP automatically when leaving Frosty. There's also a new play/pause button when in PiP mode.

Unfortunately, on iOS after some trial and error, I believe automatic PiP is not possible yet. Automatic PiP requires a true native video component, but Frosty actually uses a WebView to show streams. This is because Twitch's API doesn't provide actual stream URLs, so I had to resort to using a fullscreen version of the Twitch website instead.

I've also redesigned the video overlay to accommodate the stream uptime.

Here is a demo of everything (note: the smooth gesture transition seen below is a feature only on Android 12+):

screen-20221226-194101.mp4

As for @zeykafx's fork, there are quite a lot of major changes to go through so I'll have to set it aside until I finish working on my backlog of stuff. Hopefully, I'll find some time in the future to clean up the fork with you and will be able to have the changes merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A desirable feature that should be added
Projects
Development

Successfully merging a pull request may close this issue.

4 participants