Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential upgrades to functionality #2

Open
trcmohitmandokhot opened this issue Apr 12, 2024 · 3 comments
Open

Potential upgrades to functionality #2

trcmohitmandokhot opened this issue Apr 12, 2024 · 3 comments

Comments

@trcmohitmandokhot
Copy link

I've been tinkering around the core of the library and realized that some of the header data functions were not implemented. In particular:

  • DWGetHeaderEntryCount
  • DWGetHeaderEntryList
  • DWGetHeaderEntryText
  • DWExportHeader

So, I created a fork and attempted implement the top 3 functions into wrapper.py. Would you be interested to look at that code?.
I have tested my implementation with 64bit install of Dewesoft 2024.1, but I am not sure what more to test/implement or if my style is okay.
Would you be open to merging my fork if things are in-line with how you imagine into your current repo. Thoughts?

@trcmohitmandokhot
Copy link
Author

Here is a link to my fork for reference https://github.com/trcmohitmandokhot/dwdat2py

@tomnor
Copy link
Owner

tomnor commented Apr 13, 2024

Thanks, I will take a look during the wekeend...

@tomnor
Copy link
Owner

tomnor commented Apr 16, 2024

It was difficult to find any time but I cloned your fork and had a look. I was thinking about that text_value_size=255 argument. Is there no way to get to know the size of the entry? Is this an extra (short) description one can write about the given channel? Maybe then it is unlikely that it would be more than 255 characters. How did you choose the number 255?

But then again, any caller can apply a bigger number if required...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants