-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing css issues #251
fixing css issues #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you also check that:
Is it possible to remove ID column in candidate Signs? So a few seconds ago
can be on one line?
The ID isn't meaningful, it's just 1 to 10 on each page.
Is it also possible to have the ID/Age Sorting on the voters transactions?
Lastly, do you think it's possible to fix the spacing here?
I think it should be the same as between the network status blocks or the same as the space between each rows
Not sure, I think the ID collumn is useless here because it doesn't represent anything (click on page 2, it will still be ID 1 to 10). But we can keep it I guess. But I see you made the opposite of what I thought, you made the spacing between row the same as the spacing between "masternode" and "vote" instead of the opposite, can you change that? I think it takes too much space. |
Yep, vote for removing id column |
@pqv199x did you fixed the spacing on the status and vote button? |
I think we remove |
@khaihkd I agree, the ID column is actually always useless and give no useful information. I think it could be good to remove it everywhere. |
Also the ID on the Candidate list could be named "Rank" instead and be tied to their rank |
@etienne-napoleone I returned the spacings as they were, it's quite complex for me to fix them now |
merged it, for fixing the space, do in another PR |
Candidate transactions:
Voter transactions: