Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rank history issue #632

Merged
merged 4 commits into from
May 3, 2019
Merged

Fix rank history issue #632

merged 4 commits into from
May 3, 2019

Conversation

pqv199x
Copy link
Contributor

@pqv199x pqv199x commented May 3, 2019 •
edited
Loading

  • Add index for epoch and candidate field
  • Update crawler to store rank in last epoch, not 2 epochs behind

@coveralls
Copy link

coveralls commented May 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1286

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.47%
Totals Coverage Status
Change from base Build 1282: 0.0%
Covered Lines: 92
Relevant Lines: 103
💛 - Coveralls

@pqv199x pqv199x changed the title add index to epoch and candidate in rank table Fix rank history issue May 3, 2019
@thanhson1085 thanhson1085 merged commit 9796e35 into BuildOnViction:master May 3, 2019
@pqv199x pqv199x deleted the rank-history branch March 19, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanhson1085 thanhson1085 thanhson1085 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pqv199x @coveralls @thanhson1085