Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch event can cause aiohttp ValueError: Line is too long #137

Closed
JacobHenner opened this issue Feb 14, 2021 · 1 comment
Closed

Watch event can cause aiohttp ValueError: Line is too long #137

JacobHenner opened this issue Feb 14, 2021 · 1 comment

Comments

@JacobHenner
Copy link
Contributor

As reported in aio-libs/aiohttp#4453, aiohttp's default input stream buffer size is insufficient for some Kubernetes watch event lines. When such a line is transmitted to the client, watch.py raises a ValueError: Line is too long.

In aiohttp 3.7.0 (aio-libs/aiohttp#5065), support for configuring the buffer size was added. read_bufsize can be supplied here:

self.pool_manager = aiohttp.ClientSession(
connector=connector
)

I intend to open a PR for this tomorrow - I just need to figure out what the correct value for that parameter is.

@JacobHenner
Copy link
Contributor Author

Closed by #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant