Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences with py-export/format tools #1

Open
straup opened this issue Dec 31, 2019 · 3 comments
Open

Differences with py-export/format tools #1

straup opened this issue Dec 31, 2019 · 3 comments

Comments

@straup
Copy link

straup commented Dec 31, 2019

Noting this here for future attention. Some of these may be specific to go-whosonfirst-export:

I minified a wof document and then I played to Spot the difference between go and python exporter and here are what I found :

* No precision reduction on coordinates
* No use of utf-8 hexa codes
* Extra space after the colon
* 2 spaces instead of 4 for the indentation
* Sometime an extra space at the end of the line

whosonfirst/go-whosonfirst-export#7 (comment)

@straup
Copy link
Author

straup commented Dec 31, 2019

Related: whosonfirst/go-whosonfirst-export#8

@tomtaylor
Copy link
Member

tomtaylor commented Dec 31, 2019

@straup we should probably decide how we want to proceed here. I think the options are:

  1. Treat the Python exporter as 'the spec', and align all the other implementations to that. Pros: the least noise in the commits. Cons: the spec is pretty weird in places and can be hard to implement in other languages (e.g. a 4 space, then 2 space indentation)

  2. Come up with a new spec, and align all the implementations to that. Pros: a sensible spec could be easy to implement in all languages. Cons: potentially a lot of noise in the diffs.

  3. Some kind of compromise, trying to make the spec a little more consistent, while also trying to minimise the noise in the diffs.

Also - where's the canonical discussion of this?

@thisisaaronland
Copy link
Member

I have started an issues specific to the topic of formalizing how WOF (GeoJSON) documents are marshaled over here:

whosonfirst/whosonfirst-cookbook#35

Please weigh in with comments, suggestions and #feelings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants