Skip to content
This repository has been archived by the owner on May 23, 2022. It is now read-only.

Optimize and add features to EventStorage contract #1

Closed
tomteman opened this issue May 16, 2018 · 13 comments
Closed

Optimize and add features to EventStorage contract #1

tomteman opened this issue May 16, 2018 · 13 comments

Comments

@tomteman
Copy link
Owner

tomteman commented May 16, 2018

  1. Update contract code style to latest solidity specifications
  2. Optimize contract performance
    1. replace return as code breaks with assert statements
    2. Remove name from Attendee object and all relevant methods in the contract and update frontend app so it will not be required (in the future - to be saved off chain). List of attendees should return the addresses.
    3. Currently, all funds of all events are stored together in the contract - this should be improved, as it is probably a security concern.
    4. Find and fix additional inefficiencies
@tomteman tomteman changed the title Optimize, secure and add features to EventStorage contract Optimize and add features to EventStorage contract May 16, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.15 ETH (106.67 USD @ $711.11/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented May 17, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 6 months, 3 weeks ago.
Please review their action plans below:

1) dilatebrave has started work.

i will look into this

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@dilatebrave Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@dilatebrave
Copy link

@gitcoinbot -- i still working on this issue. Just got some problem when compiling but it's ok now. I hope i can finish it soon

@gitcoinbot
Copy link

@dilatebrave. 👋 thanks for the atMention, but you need to install @gitcoinbot on this repo for me to be able to respond. More details in the documentation.

✌️
@gitcoinbot

@dilatebrave
Copy link

@tomteman --- it looks like the current codebase got a critical bug on deposit value. I think we should store the deposit value as wei in contract, the frontend will convert to eth when display

@vs77bb
Copy link

vs77bb commented May 25, 2018

@dilatebrave @tomteman snoozing Gitcoin Bot for 3 days here

@vs77bb
Copy link

vs77bb commented Jun 6, 2018

Hi @dilatebrave @bakoah How is this and #3 going? Just checking in, hope all is well 🙂

@dilatebrave
Copy link

@vs77bb - i've done all the requirements but still waiting for @tomteman 's repsonse my last commit at PR #5

@gitcoinbot
Copy link

@dilatebrave Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.15 ETH (74.01 USD @ $493.4/ETH) has been submitted by:

  1. @dilatebrave

@tomteman please take a look at the submitted work:


@tomteman
Copy link
Owner Author

@dilatebrave sorry it took so long to merge your PR, the past two weeks have been pretty crazy. I sincerely apologize you had to wait so long, and I really hope it won't deter you from working with me again in the future, I assure you this isn't how I usually operate 😅

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.15 ETH (65.53 USD @ $436.85/ETH) attached to this issue has been approved & issued to @dilatebrave.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants