Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography REM support #106

Closed
alexdeborba opened this issue Dec 15, 2019 · 5 comments
Closed

Typography REM support #106

alexdeborba opened this issue Dec 15, 2019 · 5 comments

Comments

@alexdeborba
Copy link

Hello mates,

I have noticed that the Customiser only allows PX when it comes to Font Size under Typography and would like to suggest considering adding REM for better accessibility, as well as further compatibility with Elementor for instance, which offers this option on their typography other than limiting us to PX's.

I hope this can be considered for further releases, and it would be of great help.

@kamauwanjoroge
Copy link

kamauwanjoroge commented Dec 20, 2019

It should also include % and/or em if possible and a way to switch between them.

@badcat
Copy link

badcat commented Jun 10, 2020

As we get better tools for dealing with typography in the world of responsive designs, we're also looking at Viewport Widths (VW) etc.

Imagine when we're looking at defining our body font-size as:

body { font-size: calc(14px + (26 - 14) * ((100vw - 300px) / (1600 - 300))); }

@tomusborne
Copy link
Owner

I would definitely like the add units to the Customizer.

Could be something for GPP 1.12.0 or 1.13.0.

@swinggraphics
Copy link

@tomusborne Yes, it already looks like a field that you can change, and until I inspected the page and found it's just a span, I thought something was wrong.

@tomusborne
Copy link
Owner

We've added more units to our new Typography system in 3.1.0.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants