Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for $post in meta-box.php #246

Closed
tomusborne opened this issue Aug 20, 2021 · 0 comments · Fixed by #247
Closed

Check for $post in meta-box.php #246

tomusborne opened this issue Aug 20, 2021 · 0 comments · Fixed by #247
Labels
bug Bugs, unexpected and weird behaviors

Comments

@tomusborne
Copy link
Owner

Description

We need to check for the existence of $post before this line: https://github.com/tomusborne/generatepress/blob/3.0.4/inc/meta-box.php#L52

In some cases, it's causing PHP notice when $post doesn't exist: https://generatepress.com/forums/topic/trying-to-get-property-id-of-non-object/
@tomusborne tomusborne added bug Bugs, unexpected and weird behaviors priority: low labels Aug 20, 2021
@tomusborne tomusborne added this to the 3.1.0 milestone Aug 20, 2021
@tomusborne tomusborne mentioned this issue Aug 20, 2021
Merged
@tomusborne tomusborne linked a pull request Aug 20, 2021 that will close this issue
Check for $post->ID in metabox registration #247
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bugs, unexpected and weird behaviors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for $post->ID in metabox registration tomusborne/generatepress
1 participant
@tomusborne