Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension does not support WSL #28

Closed
YannickMG opened this issue Apr 23, 2022 · 7 comments
Closed

Extension does not support WSL #28

YannickMG opened this issue Apr 23, 2022 · 7 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@YannickMG
Copy link

Describe the bug
After selecting a new name for a component/service in the extension's renaming dialogue, nothing visibly happens.

To Reproduce
Steps to reproduce the behavior:
Try using the extension in an angular application located in the WSL file system.

Expected behavior
At least a clear error message in the "Rename Angular Component" logs which only displays the following:

------------------------
Rename Angular Component
------------------------

Screenshots or Demo Repo
In the dev tools, one can find the following error:

[Extension Host] Rename process start console.ts:137
[Extension Host] setRenameDetails error:  Error: ENOENT: no such file or directory, open 'C:\home\USERNAME\app-name\package.json'

The application is in fact located at ~/app-name in the Linux file system, but the extension tried to access the application's folder using a path that is relative to my Windows home folder.

Desktop (please complete the following information):

  • OS: Windows 11 Version 21H2 (Os Build 22000.613)
  • vscode: 1.66.2

Additional context
Unrelated but I also couldn't find a logs file to upload even after turning on the option to generate it. I might not have known where to look though.

@tomwhite007 tomwhite007 added the enhancement New feature or request label Apr 25, 2022
@tomwhite007
Copy link
Owner

Hi @YannickMG

Thanks for your thorough issue report.

WSL is certainly a platform I had yet to test on.

The symptoms you’ve given me suggest that the extension fails as the Indexer process starts to initialise by locating the package.json file.

You’ve definitely taken all sensible steps and I appreciate you trying to create a log file. The log file would have been created in the root of your project as 'rename-angular-component-debug-log.txt'. But if it’s identifying the project file root when inside WSL that is the problem - as is likely from the symptom above, then it won’t have been able to create the file in the right place.

I’ll get onto this shortly.

@DuckPluck
Copy link

Hi @tomwhite007 got same issue. Really hope you can fix it soon!

@tomwhite007
Copy link
Owner

Hi @DuckPluck
I'm intent on getting this fixed in the next update.

@tomwhite007
Copy link
Owner

Hi @YannickMG and @DuckPluck

I have run some tests, and can confirm I know what's required to upgrade the process to work on WSL. The work is not trivial, so you can watch this PR for progress: Feat/use vscode workspace fs #31 .

@tomwhite007 tomwhite007 linked a pull request Jun 23, 2022 that will close this issue
@YannickMG
Copy link
Author

Thanks for the update. I would've thought that VS code would offer some standard API it also uses when dealing with remote environments, since it's a feature they advertise so much.

@tomwhite007
Copy link
Owner

Hello @YannickMG and @DuckPluck

I put some proper time into the conversion to using vscode.workspace.fs api this week. To my horror, I've discovered the refactor which uses a reduced set of fs commands slows the extension processes down by more than 10 times. So slow that I'd lose most of my existing users.

It is with regret that I'm going to have to say, I can't support WSL.

My apologies guys, you'll have to open your project on the Windows FS side to use the extension. It's not often I say no, but my hand is forced, sorry.

@tomwhite007 tomwhite007 added the wontfix This will not be worked on label Jul 7, 2022
@tomwhite007 tomwhite007 changed the title Extension fails in WSL/remote development. Extension does not support WSL Jul 7, 2022
@YannickMG
Copy link
Author

No worries, thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants