PluginUUIDBase's force_new_uuid option seems broken

[wapiflapi]

When using PluginUUIDBase's force_new_uuid option and setting it to True I'm always getting the same uuid. Which is the opposite of what I expect.

It looks like when self.value is None a new uuid is generated, and this works fine when for the first request. But subsequent request seem to be using the same id.

I suspect the code that needs to be fixed is missing a self.value = None before trying anything else here:

starlette-context/starlette_context/plugins/plugin_uuid.py

Line 34 in 2f80262

if not self.force_new_uuid:

[wapiflapi]

Thinking about this, why is self.value being used anyway? I don't understand why this is being stored on the plugin instance. It seems like a normal variable would be enough and match the intend better, and it would have avoided this bug.

[tomwojcik]

Hey, thanks for opening this ticket. Indeed that's a bug. I'll fix this within a few days.

[tomwojcik]

0.2.3 is published. Please try again and let me know if it's all good now.

[wapiflapi]

Looks good from here!

Thank you for the quick fix.

FTR my workaround was:

# Fix https://github.com/tomwojcik/starlette-context/issues/15

__original_extract_value_from_header_by_key = (
    PluginUUIDBase.extract_value_from_header_by_key)


async def __patched_extract_value_from_header_by_key(self, request):
    self.value = None
    return await __original_extract_value_from_header_by_key(self, request)


PluginUUIDBase.extract_value_from_header_by_key = (
    __patched_extract_value_from_header_by_key
)

Removing this from my code, and using 0.2.3 all my tests still pass.
🎆 For me it looks good!

[tomwojcik]

Awesome! Thanks for checking that out.