Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toml selector .p2p not working #44

Closed
true-eye opened this issue Nov 16, 2020 · 3 comments
Closed

Toml selector .p2p not working #44

true-eye opened this issue Nov 16, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@true-eye
Copy link

true-eye commented Nov 16, 2020

Describe the bug
A clear and concise description of what the bug is.

I have a toml file which contains the following

[rpc]

abc = ""

[p2p]

persisent_peers = ""

I would like to select p2p but -p toml .p2p is not working
-p toml .rpc works. So I guess if it includes the number, then I can't use the selector?

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://dasel.tomwright.me/s/1faea436-e46e-49c0-bb44-6b30f9ed4a3c
  2. Click on Run
  3. See error

Include (sanitized) input files and commands to help along the way.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Desktop (please complete the following information):

  • OS: [e.g. iOS] MacOS
  • Version [e.g. 22] (dasel --version) latest

Additional context
Add any other context about the problem here.

@true-eye true-eye added the bug Something isn't working label Nov 16, 2020
@TomWright TomWright self-assigned this Nov 16, 2020
@TomWright
Copy link
Owner

Hey @true-eye,

It looks like this is an issue with the argument parsing on the playground rather than an issue with dasel itself.

I took the file content from the playground snippet and it works locally with dasel v1.5.1.

$ dasel -f tmp.toml .p2p
addr_book_file = "config/addrbook.json"
addr_book_strict = false
allow_duplicate_ip = false
dial_timeout = "3s"
external_address = ""
flush_throttle_timeout = "100ms"
handshake_timeout = "20s"
laddr = "tcp://0.0.0.0:26656"
max_num_inbound_peers = 40
max_num_outbound_peers = 10
max_packet_msg_payload_size = 1024
persistent_peers = ""
persistent_peers_max_dial_period = "0s"
pex = false
private_peer_ids = ""
recv_rate = 5120000
seed_mode = false
seeds = ""
send_rate = 5120000
unconditional_peer_ids = ""
upnp = false

As an aside, it's quite hard to parse the args on the playground because of the security requirements.

I believe this issue can be closed now but let me know if you're still having issues!

@TomWright
Copy link
Owner

Hey @true-eye,

The issue on the playground is now resolved. Just a note in-case you were waiting on it 🙂

@true-eye
Copy link
Author

Cool!
Too fast. :) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants