Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image is not hidden when visible={false} #50

Closed
M-i-k-e-l opened this issue Aug 10, 2020 · 1 comment
Closed

Image is not hidden when visible={false} #50

M-i-k-e-l opened this issue Aug 10, 2020 · 1 comment

Comments

@M-i-k-e-l
Copy link

M-i-k-e-l commented Aug 10, 2020 •
edited

Steps to reproduce:

  1. react-native init shimmer
  2. npm i react-native-linear-gradient --save
  3. npm i react-native-shimmer-placeholder --save
  4. pod install

Change App.js to this.

The bug: as seen in the attached video, the images are shown while the placeholder is shown.
Expected: the images will be shown only when visible={true}

Image shown video.zip
@M-i-k-e-l M-i-k-e-l mentioned this issue Aug 10, 2020
Closed
@tomzaku tomzaku closed this as completed in 38de46e Sep 1, 2020
@tomzaku
Copy link
Owner

tomzaku commented Sep 3, 2020

Can you test again? It has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix images are shown when visible={false} M-i-k-e-l/react-native-shimmer-placeholder
2 participants
@tomzaku @M-i-k-e-l