Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract: Migration contract and IDO (Jetton) #289

Closed
BeyCoder opened this issue Aug 4, 2023 · 16 comments
Closed

Contract: Migration contract and IDO (Jetton) #289

BeyCoder opened this issue Aug 4, 2023 · 16 comments
Labels
Approved This proposal is approved by the committee Developer Tool Related to tools or utilities used by developers

Comments

@BeyCoder
Copy link

BeyCoder commented Aug 4, 2023

Summary

Migration contract
This contract swaps new jettons for old (price 1=1).

IDO
This contract is used to provide IDO.

Context

Firstly, these contracts are used for our project. Our problem was name of Jetton (FragmentChecker). We decided to do re-branding of our Jetton, so, that's why we created this contracts.

Secondly, many people asked me to help with migrating their Jetton and providing IDO like us.

So, I decided that these contracts should be open-source.

Goals

Migration contract

IDO contract

Deliverables

  • Migration contract (FunC, Blueprint)
  • IDO (FunC, Blueprint)
  • Documentation for each contract

Definition of Done

Reward

  • Footstep NFT
  • $1500 in TON equivalent

Wallet for reward: EQALyrWQNCxR3RFcape5ZMxClDHpySrEO93lQiaM9ZWUnAjW

Oriental Release Date

Already released. REPOSITORY

@BeyCoder BeyCoder added the footstep This is a TON Footstep issue label Aug 4, 2023
@Gusarich
Copy link
Collaborator

Gusarich commented Aug 4, 2023

I don't quite understand what are you doing here exactly. For jetton migrations, there is already another footstep #57

@BeyCoder
Copy link
Author

BeyCoder commented Aug 4, 2023

I don't quite understand what are you doing here exactly. For jetton migrations, there is already another footstep #57

Hm... I didn't see it before. Thanks!

What do you think about IDO contract? It can be used for fix-price selling. I found only minter

@BeyCoder BeyCoder changed the title Contract: Migration contract (TEP-74) and IDO Contract: Migration contract and IDO (Jetton) Aug 4, 2023
@MaksymDS
Copy link

MaksymDS commented Aug 5, 2023

Useful work done for the community. It is important that these contracts have already been tested in a real case study. I think we should support this footstep.

@delovoyhomie
Copy link
Collaborator

This proposal will undoubtedly gain the community’s approval. However, considering the development costs, which might entail a substantial volume of work, the reward size seems quite high.
@Naltox, @krigga, @Gusarich, @aSpite, In your opinion, what compensation size would be fair and adequate in this circumstance?

@BeyCoder
Copy link
Author

This proposal will undoubtedly gain the community’s approval. However, considering the development costs, which might entail a substantial volume of work, the reward size seems quite high. @Naltox, @krigga, @Gusarich, @aSpite, In your opinion, what compensation size would be fair and adequate in this circumstance?

According to the new circumstances, what about 1500 TON + NFT (twice less)?

@delovoyhomie
Copy link
Collaborator

I recently spoke with projects that have implemented IDO contracts, and we concluded that creating a simplified contract could pose a challenge for each project in integrating their unique features and characteristics. Consequently, projects will likely still approach developers separately. Therefore, integrating such a contract into projects will be a labor-intensive process and it might be worth considering it merely as an educational resource.
@Naltox, do you think it makes sense to implement this IDO contract bounty solely for educational purposes so that people can refer to the repository and explore its working mechanics?

@aSpite
Copy link
Contributor

aSpite commented Oct 13, 2023

@delovoyhomie , @BeyCoder

I got acquainted with the code of two contracts and looked through the rest of the files.

  1. Will there be detailed tests, given that this is an interaction with tokens that may have a real price?
  2. The contract, which helps to exchange old tokens for new ones, has quite simple functionality, as with IDO. Difficulties can arise from calculations due to the difference in decimals and other validations (for example, the balance of old tokens and new ones), but in general, this is not such a difficult task.
  3. IDO is a rather individual thing and here, I did not notice any general functionality that each project could customize for itself. At the same time, handling fees is also a little strange in this contract.

Considering that similar tasks cost a maximum of $1000 (assuming all tests and detailed documentation are available), what is the basis for the current price being set at approximately $3000? Maybe I didn’t familiarize myself enough or overlooked some points that may not be immediately noticeable.

@aSpite
Copy link
Contributor

aSpite commented Oct 13, 2023

@delovoyhomie ,

When a contract is written for educational purposes, best practices should be used as much as possible, ranging from simply working with the contract repository to a detailed explanation of how all commissions were calculated and how commission checks work within the contract. In its current form, I doubt that the contract can be presented for educational purposes.

Some parts of IDO contract:

const op::set_jetton_wallet = "op::set_jetton_wallet"c;
const op::set_price = "op::set_price"c; ;; set exchange rate
const op::withdraw_jettons = "op::withdraw_jettons"c; ;; withdraw jettons
const op::withdraw = "op::withdraw"c; ;; withdraw TON
if ((op == 0xdec25470) | (op == 0)) { ;; exchange operation
        if(msg_value >= 11 * binpow(10, 8)) { ;; if amount > 1 TON + 0.1 TON(network fee)
            int jetton_amount = ((msg_value - (1 * binpow(10, 8))) / binpow(10, 9)) * price; ;; how much user will recieve, minus network fee for sending jettons (~0.1 TON)

@delovoyhomie delovoyhomie added Developer Tool Related to tools or utilities used by developers Approved This proposal is approved by the committee and removed footstep This is a TON Footstep issue labels Oct 13, 2023
@delovoyhomie
Copy link
Collaborator

@BeyCoder, let's discuss the development funding. While you have proposed 3000 TON, it seems a bit on the higher end, considering that typical projects for such contracts usually request around 1500 dollars. Could you consider this level of compensation for the current task?

@BeyCoder
Copy link
Author

@BeyCoder, let's discuss the development funding. While you have proposed 3000 TON, it seems a bit on the higher end, considering that typical projects for such contracts usually request around 1500 dollars. Could you consider this level of compensation for the current task?

Yes, I'm agree (1500$ + Footsteps NFT). Thanks!

@delovoyhomie
Copy link
Collaborator

@BeyCoder, you can start!

@delovoyhomie
Copy link
Collaborator

@BeyCoder, I am very sorry for my tactlessness regarding the assessment of the amount of remuneration and the future of this bounty in general.

I am forced to reduce the price to $450, because in bounty #305, for example, a smart contract with much more complex logic and tests was estimated at $1000. If you look at other bounties as well, we have a slightly different pricing.

If you do not agree to this amount of reward, I will close this issue and gladly consider your new one.

Once again, I ask for the hasty conclusions on the issue of assessing the scope of your proposal.

@delovoyhomie
Copy link
Collaborator

@BeyCoder, please write about your intentions to execute or not further this bounty task. We really appreciate your contribution, so we can't lose touch.

@BeyCoder
Copy link
Author

@BeyCoder, please write about your intentions to execute or not further this bounty task. We really appreciate your contribution, so we can't lose touch.

I'm not ready to do this task for this price. You can assign to someone who is ready to do this task or close this issue.

@Gusarich
Copy link
Collaborator

Who do you think will use your implementation of IDO contract? IDOs can vary greatly in functionality, rules, and other aspects. Therefore, I am sure that all projects that need to create an IDO contract will do it themselves.

@delovoyhomie delovoyhomie closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
@Amrokyarko33
Copy link

Amrokyarko33 commented Oct 24, 2023

We used the ido contract of the fck.dev project and it helped us out a lot. We have sold 500k ivs tokens worth 2000 ton. Now it is the main reserve of the project for its further development.

Contract: EQCf_kdo-g1pjPCLl3MbFW12-zkPqjM-L4h9wMe46Oa3e-rj
Our channel post: https://t.me/StalinFoundation/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This proposal is approved by the committee Developer Tool Related to tools or utilities used by developers
Projects
None yet
Development

No branches or pull requests

6 participants