-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different exit codes to indicate particular failures #412
Different exit codes to indicate particular failures #412
Conversation
Thanks I'm OOF at the moment I'll take a look ASAP |
Committed changes to PR as per code review changes. |
I'll take a look this evening after dinner, thank's! |
@sasivishnu have you retested with flags?Is it ok? |
PS. We have to remember after this PR and #422 merge we'll need to update console docs, this lead to increase minor ver as new feature. |
Yes, everything is working fine. |
… initial assignment. Co-Authored-By: Marco Rossignoli <marco.rossignoli@gmail.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@sasivishnu until @tonerdo has got some time to review could you also update .net tool guide with this new feature? https://github.com/tonerdo/coverlet/blob/master/Documentation/GlobalTool.md |
Yeah, sure... I was just waiting for @tonerdo comments on exit codes for Exceptions. Once its confirmed, then I thought to update the doc. Anyway, I will update the doc and commit it with exit codes as of now. If any changes, then I will update the doc also. |
@MarcoRossignoli Seems like this pull request branch was created before the commit of https://github.com/tonerdo/coverlet/blob/master/Documentation/GlobalTool.md I will create separate pull request for updating doc. |
Ok no worries |
@tonerdo can we merge? |
@MarcoRossignoli updated doc for this change #478 |
Closes #388
Exit Codes:
0 : Success
1 : Test failed (based on dotnet test)
2 : Coverage percentage is below any threshold type
3 : Test failed and Coverage percentage is below any threshold type
101: General exception during coverlet process
102: Missing options or invalid arguments for coverlet process
Attached the output screenshot for all the above scenarios.
ExitCodes.zip
For any exception related code, we can use values starting from 101. We can use 1-100 for any of custom failures from the process. I didn't wanted to go negative for exceptions since if someone is currently using
exitcode > 0
to determine error cases in their script, then we will be breaking them.