Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix]Fix culture for cobertura xml report #464

Merged
merged 4 commits into from
Jun 17, 2019

Conversation

MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Jun 11, 2019

Fixes #463

@boldt comes from Germany where culture uses comma as decimal separator(like Italy).
This PR fix conversion using InvariantCulture that is defined as
The invariant culture is culture-insensitive; it is associated with the English language but not with any country/region.
doc https://docs.microsoft.com/en-us/dotnet/api/system.globalization.cultureinfo.invariantculture?view=netcore-2.2

Found this useful guide on formats...english languages uses dot. https://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html

cc: @tonerdo

@MarcoRossignoli
Copy link
Collaborator Author

@tonerdo remember to change the merge strategy to "squash merge" to make easy possible reverts.

@MarcoRossignoli MarcoRossignoli changed the title Fix culture for cobertura xml report [Bug fix]Fix culture for cobertura xml report Jun 11, 2019
@MarcoRossignoli MarcoRossignoli added the bug Something isn't working label Jun 11, 2019
@tonerdo tonerdo merged commit f14ee2b into coverlet-coverage:master Jun 17, 2019
@MarcoRossignoli MarcoRossignoli deleted the coberturareport branch June 18, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong percentages within ReportGenerator
2 participants