Skip instrumentation of module with embedded ppbd without local sources

[MarcoRossignoli]

closes #476

cc: @tonerdo

[MarcoRossignoli]

@ViktorHofer does it work with corelib?

[MarcoRossignoli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[clairernovotny]

Will this also skip a module with an external PDB that doesn't have local source? That's another possible scenario that should probably be handled the same way.

[MarcoRossignoli]

Will this also skip a module with an external PDB that doesn't have local source? That's another possible scenario that should probably be handled the same way.

No this PR handle only embedded PDB...do you've some case with that issue?

[clairernovotny]

If a nuget package includes the pdb's in it, default behavior will put them in the output directory, which would lead to the same issue.

[MarcoRossignoli]

If a nuget package includes the pdb's in it, default behavior will put them in the output directory, which would lead to the same issue.

Can you point me to a package behaves like that, so I can write a test.

[clairernovotny]

I'd have to make one as I don't know one off the top of my head.

[ViktorHofer]

@ViktorHofer does it work with corelib?

I didn't test this but it should work fine as only changes to the ModuleTrackerTemplate are dangerous for CoreLib coverage.

[MarcoRossignoli]

@tonerdo can you take a look?
With this update I think that we could also remove fixed xunit filters...maybe in future.

[tonerdo]

@MarcoRossignoli we can go ahead an remove xunit filters before I make another release this Friday

[MarcoRossignoli]

@MarcoRossignoli we can go ahead an remove xunit filters before I make another release this Friday

@tonerdo I thought about a bit more...I don't know if could lead to same problem in future, I mean what if for some reason xunit will remove embedded pdb?
Maybe we could keep filter as fallback. What do you think?
EDIT: Never mind...understood I'll remove. We should also skip in case of local pdb downloaded from nuget but without source, but we need a "real sample" of such type of package to test.