[Collectors]Output multiple formats

[daveMueller]

closes #490

[MarcoRossignoli]

cc: @vagisha-nidhi for help on review.

[MarcoRossignoli]

@daveMueller can you also do some real test and share the output, we need also some integration testing, at the moment manual because we don't have in place a way to simulate all 3 drivers(msbuild, collector, console) and verify conditions, we should implement one day to keep also in sync the features between drivers cc: @tonerdo @petli

To use local build follow this guide https://github.com/tonerdo/coverlet/blob/master/Documentation/Troubleshooting.md#use-local-build let me know if you're in throuble.

[MarcoRossignoli]

Oh one more thing...you should also update documentation adding a simple comma/format to be clear that is supported https://github.com/tonerdo/coverlet/blob/master/Documentation/VSTestIntegration.md#advanced-options-supported-via-runsettings but not fundamental, thank's for your effort here.

[daveMueller]

@daveMueller can you also do some real test and share the output, we need also some integration testing, at the moment manual because we don't have in place a way to simulate all 3 drivers(msbuild, collector, console) and verify conditions, we should implement one day to keep also in sync the features between drivers cc: @tonerdo @petli

To use local build follow this guide https://github.com/tonerdo/coverlet/blob/master/Documentation/Troubleshooting.md#use-local-build let me know if you're in throuble.

Sorry somehow I can't get my local build running. After the test execution nothing else happens. Any idea how I could troubleshoot this?

[daveMueller]

Oh one more thing...you should also update documentation adding a simple comma/format to be clear that is supported https://github.com/tonerdo/coverlet/blob/master/Documentation/VSTestIntegration.md#advanced-options-supported-via-runsettings but not fundamental, thank's for your effort here.

Yes I will update the documentation after the code is 'clean'.

[daveMueller]

@MarcoRossignoli I can't figure out why the linux (release) build failed. Can you help out here?

[MarcoRossignoli]

@daveMueller I'll take a look in the afternoon or tomorrow!

[MarcoRossignoli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[MarcoRossignoli]

@MarcoRossignoli I can't figure out why the linux (release) build failed. Can you help out here?

Seem a tmp issue on azp

[MarcoRossignoli]

Sorry somehow I can't get my local build running. After the test execution nothing else happens. Any idea how I could troubleshoot this?

@daveMueller my fault we need to take another approach to debug/run local collectors code I've updated the guide, let me know if you're able to test!

https://github.com/tonerdo/coverlet/blob/master/Documentation/Troubleshooting.md#use-local-collectors-build

[daveMueller]

Oh one more thing...you should also update documentation adding a simple comma/format to be clear that is supported https://github.com/tonerdo/coverlet/blob/master/Documentation/VSTestIntegration.md#advanced-options-supported-via-runsettings but not fundamental, thank's for your effort here.

Now I've also update the documentation.

[daveMueller]

@daveMueller can you also do some real test and share the output, ...

It seems there is still something going wrong. I made some tests on windows and linux. First everything seemed to work fine. Then I tried a 3th format on linux and suddenly the DirectoryNotFoundException again. On Windows this never happened also with all formats specified.
On the linux system everthing works fine with one or two formats specified. Starting with a 3th format it throws.
I didn't have much time to look at it yet but probably you have an idea?

[MarcoRossignoli]

@daveMueller I added some code to try to solve Attachment issue...can you retry on linux?

[MarcoRossignoli]

I'd like a review by some of vstest team if possible

cc: @PBoraMSFT @vagisha-nidhi @cltshivash

[vagisha-nidhi]

Just curious. Why is this being used? Waiting for all reports to get generated?

[MarcoRossignoli]

Because with multifile we get error on directory cleanup on Linux also if we create one AttachmentManager per file, like tmp directory returned was the same. Now we use only one AttachmentManager and wait on dispose for all sends(max wait 30 sec to avoid hang) this should resolve your old issue with sync between async send and dispose, what do you think?

[vagisha-nidhi]

@MarcoRossignoli @daveMueller This looks like a great change!

[MarcoRossignoli]

LGTM thank's a lot @daveMueller for the great effort here!
I did some test on ubuntu and win and seem to work well!