Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace string concat in xmpp.MUC.XMLNS #9

Closed
aszlig opened this issue Apr 30, 2012 · 3 comments
Closed

Replace string concat in xmpp.MUC.XMLNS #9

aszlig opened this issue Apr 30, 2012 · 3 comments

Comments

@aszlig
Copy link
Contributor

aszlig commented Apr 30, 2012

According to this issue, Haxe 3 won't allow string concatenation within static inline variables, like it's used here in hxmpp.

@tong
Copy link
Owner

tong commented May 17, 2012

should be ok now

@tong tong closed this as completed May 17, 2012
@aszlig
Copy link
Contributor Author

aszlig commented May 18, 2012

We have relaxed a bit the restrictions on what we allow in inline var.
This example now works well. Int32.make will still need to use a inline function instead.

oh damn, time to revert the commit? and sorry for the noise...

@tong
Copy link
Owner

tong commented May 18, 2012

hm. i still get the error with haxe-svn. 'Inline variable must be a constant value'
anyhow, inline is gone for now, here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants