Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with DIRECTORY_SEPARATOR. #59

Closed
NautHnim opened this issue Dec 31, 2017 · 3 comments
Closed

Problem with DIRECTORY_SEPARATOR. #59

NautHnim opened this issue Dec 31, 2017 · 3 comments

Comments

@NautHnim
Copy link

I use windows OS and after install theme, i found a problem with DIRECTORY_SEPARATOR constants, when theme use asset_path function, it output the url with no separator.

Line 70, ASSETS.php:
$uri . DIRECTORY_SEPARATOR . $this->getRelativePath();

http://prntscr.com/hugboe

@jedrzejchalubek
Copy link
Collaborator

jedrzejchalubek commented Jan 2, 2018

I've moved to use fixes slash string instead of DIRECTORY_SEPARATOR constant. It looks like PHP handles these paths correctly on both win and linux.

Can you test it out with develop branch by using "tonik/gin": "dev-develop" in your composer file?

@NautHnim
Copy link
Author

NautHnim commented Jan 6, 2018

I also add "/" instead of DIRECTORY_SEPARATOR and now tonik work perfectly.
Another question, I want to add TMGPA for require plugin and Kirki for Customizer function.
What folder I can put 2 plugins TMGPA and Kirki? any recommend?

@jedrzejchalubek jedrzejchalubek added this to the 2.1.0 milestone Feb 6, 2018
@jedrzejchalubek
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants