You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, thanks for the lovely library. I haven't implemented it yet but was surprised to find the entire aws-sdk being pulled in. Surely the s3 packages would be enough no?
The text was updated successfully, but these errors were encountered:
mvandoff
changed the title
Use @aws-sdk/client-s3/@aws-sdk/s3-request-presigner packages instead of aws-sdk
Use @aws-sdk/client-s3, @aws-sdk/s3-request-presigner packages instead of aws-sdk
Nov 3, 2022
@mvandoff Sure thing, you can make a proposal PR, best would be to have these as two separated PRs so one doesn't block the other. This is just in case, as if everything looks good, I'll merge both.
Only recommendation to male things smooth: only add optional parameters on top of the existing API and use strong types.
Hello, thanks for the lovely library. I haven't implemented it yet but was surprised to find the entire aws-sdk being pulled in. Surely the s3 packages would be enough no?
The text was updated successfully, but these errors were encountered: