Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @aws-sdk/client-s3, @aws-sdk/s3-request-presigner packages instead of aws-sdk #9

Open
mvandoff opened this issue Nov 3, 2022 · 4 comments

Comments

@mvandoff
Copy link

mvandoff commented Nov 3, 2022

Hello, thanks for the lovely library. I haven't implemented it yet but was surprised to find the entire aws-sdk being pulled in. Surely the s3 packages would be enough no?

@mvandoff mvandoff changed the title Use @aws-sdk/client-s3/@aws-sdk/s3-request-presigner packages instead of aws-sdk Use @aws-sdk/client-s3, @aws-sdk/s3-request-presigner packages instead of aws-sdk Nov 3, 2022
@toniopelo
Copy link
Owner

I guess you're right @mvandoff, this is a good point. Would you be willing to create a PR ? :)

@mvandoff
Copy link
Author

mvandoff commented Nov 5, 2022

Life is hectic right now but I'll look into it.

@mvandoff
Copy link
Author

mvandoff commented Nov 5, 2022

@toniopelo I need to be able to add metadata to the uploads, can I add support for that while I'm at it?

@toniopelo
Copy link
Owner

@mvandoff Sure thing, you can make a proposal PR, best would be to have these as two separated PRs so one doesn't block the other. This is just in case, as if everything looks good, I'll merge both.
Only recommendation to male things smooth: only add optional parameters on top of the existing API and use strong types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants