Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jetton onchain metadata support #197

Closed
wants to merge 9 commits into from

Conversation

shaharyakir
Copy link

See #189

This adds support for reading metadata for jettons which is stored onchain, alongside the existing offchain support.

image

Example jetton address: EQDfLSpVoAYo9_reMujMv6QFGDI4vntaVgzGGrAImwL3zeZC

Tested on Android/RN.

@ex3ndr
Copy link
Contributor

ex3ndr commented Jul 17, 2022

Hello! We are still reviewing and not forgetting about this PR the problem is that we will move to backend-based metadata or hardcode all good coins, and we are still figuring out the best way to do so.

@shaharyakir
Copy link
Author

Anything we can do to help decide and/or contribute to implementing the backend code for onchain parsing?

Re hardcoding good coins, as a user I probably would still like to see all of my jettons, maybe some would be hidden under a folder if not verified or marked as verified if they belong in the list?

@shaharyakir
Copy link
Author

Giving it more thought, parsing jetton metadata in the backend may well be defeating the purpose of storing these metadata on chain. The less processing is done on a proprietary backend, the safer it is for the user.

@ex3ndr
Copy link
Contributor

ex3ndr commented Aug 27, 2022

Hello! Our current implementation relies on our backend for now and supports on-chain metadata. Eventually, we will be able to move everything on-chain to a specific contract that is managed by some DAO and we will remove dependency from our backend.

@ex3ndr ex3ndr closed this Aug 27, 2022
@shaharyakir
Copy link
Author

@ex3ndr thanks for the update, I tested it with previously created jettons and a new one, currently they are not displayed in tonwhales explorer nor the wallet.

Was it supposed to work already?

(Example jetton - https://jetton.live/jetton/EQD8a5p-Imf9cU55wB66guXwNSGv8lSGg-zFregbVXY0V51L)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants