Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding Python 3.5 support #12

Closed
tonybaloney opened this issue Nov 12, 2018 · 6 comments
Closed

Consider adding Python 3.5 support #12

tonybaloney opened this issue Nov 12, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@tonybaloney
Copy link
Owner

This project uses black, but that's not a requirement to execute it. It also uses f-strings, but those could be replaced with str.format easily

Please 馃憤 if you want to see this back-ported to 3.5

@tonybaloney
Copy link
Owner Author

Would also require dropping use of dataclasses for something else, eg. namedtuples or attrs

@tonybaloney tonybaloney self-assigned this Nov 16, 2018
@tonybaloney tonybaloney added the enhancement New feature or request label Nov 16, 2018
@tonybaloney
Copy link
Owner Author

Raised WIP in #15

@Kilo59
Copy link

Kilo59 commented Nov 21, 2018

If you are already on 3.5 what's holding you back from moving up to 3.6?

EDIT:
I thought I was talking to a potential user, not the author. 馃檭

@tonybaloney
Copy link
Owner Author

@Kilo59 other way around. It supports 3.6 and 3.7 already. I'm considering back-porting to 3.5

@Kilo59
Copy link

Kilo59 commented Nov 25, 2018

@tonybaloney I understand what you are asking. I was actually asking you what's stopping your one's project (in which you someone wants to use wily) from moving from 3.5 to 3.6 (or 3.7).

I could be wrong of course, but I don't see a lot of developers being stuck on 3.5 and unable to move up to 3.6+ actually being very common.
IMO having to support an older version of python and maintain it may start out relatively easy at first but can really start to slow down development as features get added and the project grows in complexity.

EDIT:

馃檭 When I originally responded I didn't realize I was talking to the project author, whoops.
Anyways was trying to save you some work, not intentionally trying to be difficult. 馃槃

@Kilo59
Copy link

Kilo59 commented Nov 25, 2018

In addition, adding more dependencies to support 3.5 is going to introduce more chances for dependency problems. I've already had issues with wily, flake8, pyflakes and prospector (fixed it by pinning flake8 to an earlier release 3.5.0) .

I imagine people who are likely to install wily are also likely to be running other static analysis tools too, increasing the likelihood of problems.

@tonybaloney tonybaloney added the wontfix This will not be worked on label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants