Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more complex searches in filter by default #38

Closed
TonyGermaneri opened this issue Aug 18, 2017 · 1 comment
Closed

Support more complex searches in filter by default #38

TonyGermaneri opened this issue Aug 18, 2017 · 1 comment
Milestone

Comments

@TonyGermaneri
Copy link
Owner

TonyGermaneri commented Aug 18, 2017

Currently, it is not clear the filter is a regexp interface. This means laymen cannot search for strings that contain reserved characters (such as parentheses). Instead of just straight regexp interface, we should use a string pattern to switch regex on and off. /<pat>/<flags> is the standard pattern. So any string matching this pattern will be considered regexp and parsed accordingly. Further, on error of regexp self.invalidFilterRegEx = e; should be set to the regexp error. If not using regex (pattern does not match /<pat>/<flags>) then self.invalidFilterRegEx = false; should be set to boolean false. When using regex and no error has been detected self.invalidFilterRegEx = true; should be set to boolean true to give a visual cue to the user that they are using regex and not just string matching.

@TonyGermaneri TonyGermaneri added this to the V1 milestone Aug 18, 2017
TonyGermaneri added a commit that referenced this issue Sep 4, 2017
…e selectionMode = row. Added more complex search logic see issue #38. Renamed attribute childGridAttributes to cellGridAttributes deprecating childGridAttributes.  Updated debug display to show more info horizontally.  Fixed a bug in selection values when columns are hidden.  Fixed a bug in copy where non-string values would crash the copy function.  Updated touch default values to less sub-optimal values, still considered a wip.  Truncating autocomplete items to maxAutoCompleteItems=200.  Updated docs.
@TonyGermaneri
Copy link
Owner Author

This feature is now implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant