Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P5 component prop project just gets overwritten on instance init #124

Closed
tonyketcham opened this issue Apr 3, 2022 · 1 comment · Fixed by #120
Closed

P5 component prop project just gets overwritten on instance init #124

tonyketcham opened this issue Apr 3, 2022 · 1 comment · Fixed by #120
Labels
bug Something isn't working

Comments

@tonyketcham
Copy link
Owner

Describe the bug
Passing in a p5 instance to the project prop does nothing and just gets overwritten when the p5 sketch initializes:

<P5 {sketch} {project} />

It should be made private to the P5.svelte component and an experiment on feature/linked-instances may lead to a future PR introducing the ability to create multiple viewports of the same sketch via passing around a p5 project, presuming that is supported in p5's instance mode.

@tonyketcham tonyketcham added the bug Something isn't working label Apr 3, 2022
@tonyketcham
Copy link
Owner Author

tonyketcham commented Apr 3, 2022

Fixing this will lead to a niche & mild breaking change which shouldn't actually break any sketches themselves but could break CI where users have eslint or svelte-check jobs that detect an attempt to pass to a non-existant prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant