Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove derive_builder as a dependency #240

Open
3 tasks
tonymushah opened this issue Jun 14, 2024 · 0 comments
Open
3 tasks

Remove derive_builder as a dependency #240

tonymushah opened this issue Jun 14, 2024 · 0 comments
Labels
breaking-change Something that will change the code base core everything that related to the `mangadex-api` crates core-types enhancement New feature or request input-types everything that related to the `mangadex-api-input-types` crates
Milestone

Comments

@tonymushah
Copy link
Owner

Hello everyone! I'm sure you all doing well.

Anyway, after a long time of learning and practising Rust, I'm finally decided to remove derive_builder as a dependency.

If you don't know (yet), derive_builder is the library that used to build an endpoint struct.

It was already mentioned by @gondolyr (the old maintainer) and put in #2 for quite some time now, but back then my Rust skills are poor than now.

What's the plan?

  • Remove derive_builder on each Cargo.toml
  • Make a derive macro that handle this endpoint building for us
  • Spend more than it should to refactor each endpoint

Normally, when it's done, it should the same syntax as the one that we use now.

@tonymushah tonymushah added enhancement New feature or request breaking-change Something that will change the code base input-types everything that related to the `mangadex-api-input-types` crates core everything that related to the `mangadex-api` crates core-types labels Jun 14, 2024
@tonymushah tonymushah added this to the 4.0.0 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Something that will change the code base core everything that related to the `mangadex-api` crates core-types enhancement New feature or request input-types everything that related to the `mangadex-api-input-types` crates
Projects
None yet
Development

No branches or pull requests

1 participant