Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate javascript code from HTML file #9

Closed
srish opened this issue May 23, 2019 · 3 comments
Closed

Separate javascript code from HTML file #9

srish opened this issue May 23, 2019 · 3 comments
Assignees

Comments

@srish
Copy link
Collaborator

srish commented May 23, 2019

Well, it was a Hackathon, but this file is really messed up https://github.com/tonythomas01/gdrive_to_commons/blob/master/uploader/templates/base/base.html ;-)

All the javascript code needs to be moved out in a separate file.

@srish srish self-assigned this May 23, 2019
@tonythomas01
Copy link
Owner

Sure. I just brought back things to home.html without even looking at this issue. Great we have it reported.

Now probably someone should split the things in home.html (scripts, etc).

@NdibeRaymond
Copy link

NdibeRaymond commented Mar 8, 2020

Hello @srish and @tonythomas01 , I am an outreachy aspirant and I would love to work on this issue

@tonythomas01
Copy link
Owner

Closing this for now, as it should come more as a refactoring challenge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants