Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Cloth Reader #14

Open
andrewkaufman opened this issue Mar 25, 2019 · 1 comment
Open

Rework Cloth Reader #14

andrewkaufman opened this issue Mar 25, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@andrewkaufman
Copy link
Collaborator

Is there a good reason to have the AtomsCrowdClothReader as a standalone node? It seems to just add extra data onto the points coming out of the AtomsCrowdReader before piping them into the generator. Can we move this functionality to the AtomsCrowdReader instead?

@andrewkaufman andrewkaufman added the enhancement New feature or request label Mar 25, 2019
@andrewkaufman
Copy link
Collaborator Author

After using the ClothReader in production a bit, we feel it should remain a separate node, but should not require a 3rd input on the Generator. The current graph in the example script looks like:

CrowdReader -> Generator
VariationReader -> Generator
CrowdReader -> ClothReader -> Generator

but the new proposed graph would be:

CrowdReader -> ClothReader -> Generator
VariationReader -> Generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant