Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commits to release draft #98

Open
dcastil opened this issue Dec 8, 2018 · 9 comments
Open

Add commits to release draft #98

dcastil opened this issue Dec 8, 2018 · 9 comments

Comments

@dcastil
Copy link

dcastil commented Dec 8, 2018

Hi @toolmantim, thanks for this great app!

It would be nice to be able to add commits to the triggerable branch to the release as well. This would be especially helpful for small or young projects.

For example a boolean property track-commits could be added to the config to enable the functionality. Then the message according to change-template is created with $TITLE set to the commit title and $NUMBER set to the commit hash.

I might be able to work on this on my own if I find time for it. Just want to find out if this is desired.

@toolmantim
Copy link
Collaborator

Sounds like a useful option for some peeps!

Perhaps we have new options and new variables? $COMMITS for example?

@dcastil
Copy link
Author

dcastil commented Dec 8, 2018

But then it isn't ordered chronologically anymore. I'd like to treat commits the same as PRs and don't separate them.

So the draft looks like this:

## What's Changed

* First PR (#<number>)
* Some commit (<hash>)
* Second PR (#<number>)

@toolmantim
Copy link
Collaborator

I see! Cool, that makes sense. I wonder if "include" is a better word than "track" for the option? Perhaps include-all-commits: true?

@dcastil
Copy link
Author

dcastil commented Dec 9, 2018

Yes, that sounds good! 👍

But I just realised that commits would need its own template as the $NUMBER variable for a PR is likely to be prepended by a # whereas a commit hash isn't.

@pkiv
Copy link

pkiv commented Oct 3, 2021

Just bumping this request, I think this would be really handy!

@caesay
Copy link

caesay commented Mar 11, 2022

Ditto, this would be amazing

@jetersen
Copy link
Member

see #552 as well.

How would you support categorization of commits?

@caesay
Copy link

caesay commented Mar 11, 2022

Looks like these discussions should get merged and this issue should be closed. I agree with the comments at #552 - grouping up into a default category (eg. Other) and allowing the commit message to optionally pick a category using some predetermined syntax.

If a category "Bug Fixes" has the label "bug", and the commit message is "bug: Fixed Blah" it could be automatically grouped into this category.

@mehdihadeli
Copy link
Contributor

mehdihadeli commented Jan 3, 2023

google-github-actions/release-please-action do this with conventional commits and categorize them based on the conventional commits type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants