Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user control of LoopChecker#maxLoopLength limit #69

Closed
DexterShepherd opened this issue Dec 6, 2017 · 1 comment
Closed

Add user control of LoopChecker#maxLoopLength limit #69

DexterShepherd opened this issue Dec 6, 2017 · 1 comment

Comments

@DexterShepherd
Copy link

Hey All,

Thanks for the great widget! I recently needed to load a fairly large .obj into a sketch during preload() and ran up against the LoopChecker killing my sketch before I was able to load the resource. Forking the repo and commenting out the error throwing line in LoopChecker fixed the issue.

Would you be open to a PR adding data-loopcheck-enable and/or data-loopcheck-length as user configurable parameters on the parent <script> element?

Thanks again,

Dexter

@toolness
Copy link
Owner

toolness commented Dec 6, 2017

Oh that's a great idea! Sure, I'd be happy to accept such a PR, thanks for offering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants