Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

Godep stopped importing a dependency #490

Closed
aanm opened this issue Jun 9, 2016 · 5 comments
Closed

Godep stopped importing a dependency #490

aanm opened this issue Jun 9, 2016 · 5 comments

Comments

@aanm
Copy link

aanm commented Jun 9, 2016

I'm using a dependency that imports github.com/prometheus/common

godep version godep v71 (linux/amd64/go1.6) doesn't seems to import the github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg directory to vendor so I got a:

$ go install ./...
....
  imports github.com/prometheus/common/expfmt
  imports github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg: use of internal package not allowed

An old godep version (I believe v62) had imported github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg because the file was in vendor directory before. If I put the dependency by hand inside the vendor directory, the project compiles without any problem.

Linking to prometheus issue prometheus/common#45

@freeformz
Copy link

What does your Godeps.json file look like ?

@mkumatag
Copy link

I also faced this issue while building k8s.io/heapster project with updated github.com/boltdb/bolt, any update on this issue?

@aanm
Copy link
Author

aanm commented Jul 5, 2016

@mkumatag can you provide a copy of your Godeps.json file so @freeformz can have a look at it? I wasn't able to reproduce the problem afterwards.

@freeformz
Copy link

I can't reproduce this. When I require "github.com/prometheus/common/expfmt" and godep save I get "github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg" vendored. Can you explain which dep requires this? Is it vendored there? Do you have the same version vendored there on your GOPATH?

@aanm
Copy link
Author

aanm commented Sep 9, 2016

Closing this issue since the linked issue was also closed.

@aanm aanm closed this as completed Sep 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants