Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in IE8 #54

Closed
ncri opened this issue Mar 17, 2014 · 6 comments
Closed

Doesn't work in IE8 #54

ncri opened this issue Mar 17, 2014 · 6 comments

Comments

@ncri
Copy link

ncri commented Mar 17, 2014

Is that a known issue?

For example I cannot make text italic on your demo page http://toopay.github.io/bootstrap-markdown/ when using IE 8. Clicking the I icon produces a js error:

SCRIPT438: Object doesn't support property or method 'indexOf' 
bootstrap-markdown.js, line 154 character 11
@acrobat
Copy link
Contributor

acrobat commented Jun 10, 2014

@toopay is IE8 something you want to support or IE9 and up? Otherwise I could take a look to do some fixes to improve IE8 support

@emagnier
Copy link
Contributor

The use of es5-shim could probably help for that. But we also have to live with the times. IE8 is now not supported by Microsoft (since they drop the support of Windows XP).

@ncri
Copy link
Author

ncri commented Jun 10, 2014

I'd love to drop IE8 as well, however, a significant part of our users still use it and we simply cannot afford to not support them.

@toopay
Copy link
Member

toopay commented Jun 27, 2014

Sorry guys, i just don't see the need to support IE8. But @acrobat if you want to make an effort to support IE9, please do.

@toopay toopay closed this as completed Jun 27, 2014
@ncri
Copy link
Author

ncri commented Jun 27, 2014

Well, the need is there obviously, as i wrote. Of cause you can choose to ignore it. ;-)

Although i would have probably decided similar... The earlier we get rid of IE8 the better. If the users see broken sites with IE8, they might have an insentive to upgrade. ;-)

@acrobat
Copy link
Contributor

acrobat commented Jun 27, 2014

I'm going to take a look at IE9 support, but i also will try to find some external libs (like es5-shim) to add IE8 support without much (or even none?) effort and change in the current code. (just some tips/tricks in the docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants