Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add express typings #56

Merged
merged 2 commits into from
Apr 18, 2021
Merged

Add express typings #56

merged 2 commits into from
Apr 18, 2021

Conversation

darenliang
Copy link
Contributor

@darenliang darenliang commented Apr 18, 2021

Installing @top-gg/sdk inside of a TypeScript project results in the following error when building:

$ npm run build

> test@1.0.0 build /test
> tsc --build tsconfig.json

node_modules/@top-gg/sdk/dist/structs/Webhook.d.ts:1:49 - error TS2307: Cannot find module 'express' or its corresponding type declarations.

1 import { Request, Response, NextFunction } from 'express';
                                                  ~~~~~~~~~


Found 1 error.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! test@1.0.0 build: `tsc --build tsconfig.json`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the test@1.0.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

This PR adds express typings and updates deps.

jpbberry
jpbberry previously approved these changes Apr 18, 2021
@jpbberry jpbberry merged commit 314da60 into Top-gg-Community:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants