Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin App] Endpoint to manage users who signed a particular Terms #40

Closed
maxceem opened this issue Sep 22, 2020 · 2 comments
Closed

[Admin App] Endpoint to manage users who signed a particular Terms #40

maxceem opened this issue Sep 22, 2020 · 2 comments
Assignees
Labels

Comments

@maxceem
Copy link
Contributor

maxceem commented Sep 22, 2020

We need this feature to manage Terms in Admin App see topcoder-platform/admin-app#153.

Overview

Admins should be able to list users who signed a particular Terms Of User. Additionally admins should be able to sign or unsign Terms for other users.
I suggest adding a new endpoint/terms/:termsOfUseId/users with GET/POST/DELETE commands.

List - GET /terms/:termsOfUseId/users

This endpoint should return a list of users who signed Terms specified by termsOfUseId.

  • As there might be a lot of users who signed one Terms, this endpoint should support pagination: page / perPage query params.
  • Additionally, it might be good to have filters by:
    • userId - so we can quickly check if a particular user has signed the Terms. Also, it might be great, if we can support filtering by multiple users by providing a comma-separated list of users like GET /terms/:termsOfUseId/users?userId=111111,222222,333333,444444.
    • 2 query params signedAtFrom and signedAtTo to filter by the date when terms was signed. We can define one of these params or both of them. (UserTermsOfUseXref model has field created which could be used for this filter).

Sign - POST /terms/:termsOfUseId/users/

  • Should accept body in JSON format like:

    {
      "userId": 123456 // the id of user who should sign the Terms
    }

Unsign - DELETE /terms/:termsOfUseId/users/:userId

Should unsign the terms termsOfUseId for user specified by userId

@rootelement
Copy link
Contributor

@maxceem I believe this is completed and can be closed right?

@maxceem
Copy link
Contributor Author

maxceem commented Apr 29, 2021

Yes, closing.

@maxceem maxceem closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants