rtRemote - Additional code cleanup

[jmgasper]

Additional code quality items from the recent review:

Issue 1:

Logger should be final:

  private static Logger logger = Logger.getLogger(...);

Issue 2:

The object maps should be final, they're not reinitialized:

  /**
  * the static map used to store local object, so that getObject can found the real local object
  */
  private static Map<string rtlocalobject> objectMap
      = new ConcurrentHashMap();
  /**
  * the remote object map, thread safe
  */
  private static Map<string uri> objectMap = new ConcurrentHashMap();

Issue 3:

Why do you use "this" to qualify objName but not value which is also an instance variable:

      this.objName = "obj://" + UUID.randomUUID().toString();
      value = buildValue();

Issue 4:

Should be private, not used outside class:

  public JsonObject buildValue() {
    JsonObjectBuilder builder = Json.createObjectBuilder();
    builder.add("object.id", this.objName);
    return builder.build();
  }

public void sendCallResponse(String correlationKey) throws RTException {

public void setListener(RTFunctionListener listener) {

Issue 5:

Should define a constant for property name "object.id":

    String objName = value.getString("object.id");
    builder.add("object.id", this.objName);

Should define a constant for property name "function.name":

    rtFunction.setFuncName(jsonObject.getString("function.name"));
    builder.add("function.name", funcName);

Issue 6: