Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port websocket ('ws') support to V8 build of Spark / pxScene #231

Closed
jmgasper opened this issue Oct 31, 2018 · 0 comments
Closed

Port websocket ('ws') support to V8 build of Spark / pxScene #231

jmgasper opened this issue Oct 31, 2018 · 0 comments

Comments

@jmgasper
Copy link
Collaborator

We have recently done work to support V8 as a Javascript engine for pxScene. This work has shown it is a viable option. This challenge will expand the V8 integration to support the ws library:

https://github.com/gladish/pxCore/tree/master/examples/pxScene2d/external/uWebSockets-0.14.8

We did this previously as part of the __temp_RF_rtRemoteWebsocket branch. You can see the initial pull request and merge here:

#196

There are a few tests here that specifically use the 'ws' module and can be used for testing. Please use these on the default Node build of the app (or just download from pxscene.org) to compare with the fixed up V8 build:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant