Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pxBrowser Updates #249

Closed
jmgasper opened this issue Dec 18, 2018 · 0 comments
Closed

pxBrowser Updates #249

jmgasper opened this issue Dec 18, 2018 · 0 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Dec 18, 2018

The client has asked that we make some updates to the pxBrowser example we created here. We really need to keep Qt separate from the rest of the app. There can't be any dependency "leakage" from our pxBrowserView into the rest of pxCore.

https://github.com/topcoderinc/pxCore/tree/qt_browser

  1. Rename pxCore/examples/pxScene2d/src/qtview/ to pxCore/examples/pxScene2d/src/browser/qt/
  2. Move all newly created files related to Qt and the browser into pxCore/examples/pxScene2d/src/browser/qt/ (including those inside of pxCore/src/qtview)
  3. Remove all Qt references (including QApplication) from pxWindowNative and any other file outside of pxCore/examples/pxScene2d/src/browser/qt/
  4. Create a static QApplication object inside of pxBrowserView to be used by all pxBrowserView objects
  5. Call sendPostedEvents() on the QApplication inside of pxBrowserView::onUpdate()
  6. The pxCore/examples/pxScene2d/src/CMakeLists.txt can have references to linking against Qt libs and including Qt header search paths
  7. Add any needed Qt externals to pxCore/examples/pxScene2d/external/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant