Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mercurial metadata #91

Open
sjl opened this issue Jun 17, 2010 · 8 comments
Open

Add support for Mercurial metadata #91

sjl opened this issue Jun 17, 2010 · 8 comments

Comments

@sjl
Copy link

sjl commented Jun 17, 2010

This would be really handy for those of use that use Mercurial.

I'm not sure exactly what metadata you pull from git, but I can tell you how to get it from Mercurial if you list it.

Or if you open-source the metadata-getting part of the code I can write it.

@topfunky
Copy link
Owner

My initial roadblock is that Mercurial doesn't seem to offer an equivalent of Git's "git diff --numstat":

0       1       app/controllers/javascripts_controller.rb
11      1       app/helpers/reports_helper.rb
1       2       app/views/reports/index.haml

The alternative is to implement this within PeepOpen, but it could be slow to do it in Ruby, external to Mercurial.

Your suggestion of a more extensible metadata system is a good one. The PeepOpen source is available where you initially purchased and downloaded the application.

https://peepcode.com/products/peepopen

My initial task is to implement a better system for launching external commands with the user's PATH taken into account (Cocoa doesn't do this by default). Once I implement that, it would be easier to integrate other SCMs.

@sjl
Copy link
Author

sjl commented Jun 18, 2010

You're right, Mercurial doesn't have --numstat. I noticed you were using that when browsing some of the other issues, and sent a patch to add it, but after talking with mpm it doesn't look like it's going in. It's trivial to do what --numstat does by counting diff lines and mpm didn't want to clutter the Mercurial codebase more.

I didn't notice that the download included the source -- that's pretty cool. I'll take a look.

One thing though: when I click my download link it gives me 0.2.0, not 0.2.1. Has enough changed since then that I may want to be wary of merge conflicts for you guys?

@sjl
Copy link
Author

sjl commented Jun 18, 2010

OK, I poked around and added support for Mercurial (and refactored just a tiny bit). Is there somewhere I could send a patch to have it looked at? I'm not a Ruby programmer so I'm sure it can be cleaned up a bit, but at least it works.

@sjl
Copy link
Author

sjl commented Jul 11, 2010

Still got the patch if you want it.

@topfunky
Copy link
Owner

Apologies for the delay. Would love to integrate the patch. Email boss@topfunky.com

@lcantey
Copy link

lcantey commented Jan 7, 2011

Any update on this?

@levifig
Copy link

levifig commented Jun 17, 2011

Has this been integrated?

@lcantey
Copy link

lcantey commented Jun 20, 2011

It's not reporting metadata for Mercurial as of 0.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants