Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: show a confirmation dialog before installing a module from filesystem #4550

Closed
Fs00 opened this issue Aug 14, 2021 · 5 comments · Fixed by #6710
Closed

Suggestion: show a confirmation dialog before installing a module from filesystem #4550

Fs00 opened this issue Aug 14, 2021 · 5 comments · Fixed by #6710
Labels
app This issue is related to Magisk App enhancement New feature request

Comments

@Fs00
Copy link
Contributor

Fs00 commented Aug 14, 2021

Hello everyone,
I'd like to propose a small QoL change to the Magisk app.
Currently, when you install a module from the filesystem, the installation starts as soon as the ZIP gets selected from the file picker. This is far from ideal since, if you select the wrong ZIP by mistake (e.g. when you have multiple modules in the same folder), there is no way to go back before the installation starts.
Therefore I propose to add a confirmation dialog that should appear after the user selects the ZIP, which also displays basic information on the module that is about to be installed (author, name, version). This last addition would be very helpful to make sure that the right file has been selected.
Thanks!

--
Device: not relevant
Android version: any
Magisk version name: 23.0
Magisk version code: 23001

@techIndia-hacker
Copy link

Yes this is important. But my question is what happens to magisk without the creator 😶

@spoxed

This comment was marked as off-topic.

@techIndia-hacker

This comment was marked as off-topic.

@elschman
Copy link

Even support this request

@stylemessiah
Copy link

This needs a new bump

@yujincheng08 yujincheng08 added the app This issue is related to Magisk App label Mar 2, 2023
@yujincheng08 yujincheng08 linked a pull request Mar 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app This issue is related to Magisk App enhancement New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants