Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot animation replacement doesn't work since 16.4 #562

Closed
TpmKranz opened this issue Sep 3, 2018 · 4 comments
Closed

Boot animation replacement doesn't work since 16.4 #562

TpmKranz opened this issue Sep 3, 2018 · 4 comments
Labels
confirmed Issue confirmed to exist and the reason is known

Comments

@TpmKranz
Copy link

TpmKranz commented Sep 3, 2018

Upgrading from 16.0 to 17.1, I noticed that the boot animation from @osm0sis' Nexus Media module doesn't override my (rather obnoxious) stock boot animation anymore.

A bit more investigation produced that it stopped working with Magisk 16.4.

I'll attach the Magisk logs of every version I tried:

Is this a Magisk bug/feature or should I open an issue at the module's repo?

Thank you for everything!

@Didgeridoohan
Copy link
Contributor

That's a side effect of removing the post-fs stage and replacing it with a new simple mount that unfortunately doesn't kick in early enough on all devices.

https://forum.xda-developers.com/showpost.php?p=76371726&postcount=42

@TpmKranz
Copy link
Author

TpmKranz commented Sep 5, 2018

Shoot, so no easy fix for me, except switching to a device where the mounting happens to happen early enough?

Is it something @topjohnwu plans to/wants to/can fix? If so, I'd gladly help testing; I'm on a Moto Z2 Play with stock Oreo 8.0, KEEPVERITY and KEEPFORCEENCRYPT both set to true and a device password set.

@osm0sis
Copy link
Collaborator

osm0sis commented Sep 5, 2018

Nope. He made everything post-fs-data to simplify it and has no intention of adding post-fs back. On all new devices /cache is just symlinked to /data/cache so would need to wait for post-fs-data anyway.

Only solution for you is to force my module to install to /system by renaming it with -system in the filename and flashing it from recovery.

@TpmKranz
Copy link
Author

TpmKranz commented Sep 5, 2018

Bummer. Thanks for taking the time to explain it to me.

I'd hoped to stay completely systemless since not keeping dm-verity complicates modding on my phone/stock firmware. (If anyone's interested, read this and this.)

If @topjohnwu ever changes his mind, I'll be here ready to test (and get rid of that awful bootanimation systemlessly 😋).

Please close this issue at your discretion, and thanks again. Have a nice day, y'all!

@topjohnwu topjohnwu added the confirmed Issue confirmed to exist and the reason is known label Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Issue confirmed to exist and the reason is known
Projects
None yet
Development

No branches or pull requests

4 participants