-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boot animation replacement doesn't work since 16.4 #562
Comments
That's a side effect of removing the post-fs stage and replacing it with a new simple mount that unfortunately doesn't kick in early enough on all devices. https://forum.xda-developers.com/showpost.php?p=76371726&postcount=42 |
Shoot, so no easy fix for me, except switching to a device where the mounting happens to happen early enough? Is it something @topjohnwu plans to/wants to/can fix? If so, I'd gladly help testing; I'm on a Moto Z2 Play with stock Oreo 8.0, |
Nope. He made everything post-fs-data to simplify it and has no intention of adding post-fs back. On all new devices /cache is just symlinked to /data/cache so would need to wait for post-fs-data anyway. Only solution for you is to force my module to install to /system by renaming it with -system in the filename and flashing it from recovery. |
Bummer. Thanks for taking the time to explain it to me. I'd hoped to stay completely systemless since not keeping dm-verity complicates modding on my phone/stock firmware. (If anyone's interested, read this and this.) If @topjohnwu ever changes his mind, I'll be here ready to test (and get rid of that awful bootanimation systemlessly 😋). Please close this issue at your discretion, and thanks again. Have a nice day, y'all! |
Upgrading from 16.0 to 17.1, I noticed that the boot animation from @osm0sis' Nexus Media module doesn't override my (rather obnoxious) stock boot animation anymore.
A bit more investigation produced that it stopped working with Magisk 16.4.
I'll attach the Magisk logs of every version I tried:
Is this a Magisk bug/feature or should I open an issue at the module's repo?
Thank you for everything!
The text was updated successfully, but these errors were encountered: